Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment typo fix #1425

Merged
merged 2 commits into from
Sep 24, 2020
Merged

comment typo fix #1425

merged 2 commits into from
Sep 24, 2020

Conversation

akhmerov
Copy link
Member

Nothing of importance, but made me think what is meant for a second. (Unless I really misunderstood, in which case sorry!)

MSeal
MSeal approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, would you mind also applying the change to the latex/null.j2 template file?

@akhmerov
Copy link
Member Author

I was about to do so, but it says that it shouldn't be edited manually; I assumed it's regenerated automaticaly. Is manual edit OK?

@akhmerov
Copy link
Member Author

In case a manual edit is OK, it's done now.

@MSeal
Copy link
Contributor

MSeal commented Sep 24, 2020

Yeah should be fine I think

@MSeal MSeal merged commit 8809e7c into jupyter:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhmerov @MSeal